Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage increase #89

Merged
merged 23 commits into from
Mar 18, 2024
Merged

Test coverage increase #89

merged 23 commits into from
Mar 18, 2024

Conversation

rfsbraz
Copy link
Owner

@rfsbraz rfsbraz commented Mar 7, 2024

In order to make Deleterr more easily extendable I want to refactor the architecture into a data pipeline architecture, but for that I need to first increase the test coverage so that I can guarantee compatibility.

@rfsbraz rfsbraz self-assigned this Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

🤖 A Docker image for this PR is available to test with:

docker run -e LOG_LEVEL=DEBUG --rm -v ./config:/config -v ./logs:/config/logs ghcr.io/rfsbraz/deleterr:pr-89

This assumes you have a config and logs directory where you're running the command. You can adjust the volume mounts as needed.

Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
22.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@rfsbraz rfsbraz changed the title Refactors Architecture refactor Mar 10, 2024
@rfsbraz rfsbraz changed the title Architecture refactor Test coverage increase Mar 18, 2024
Copy link

@rfsbraz rfsbraz merged commit a13e258 into develop Mar 18, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the chore/refactors branch March 18, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant