Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Remove the need for gocryptfs.conf, with secure master password input #218

Closed
antofthy opened this issue Mar 19, 2018 · 7 comments

Comments

@antofthy
Copy link

antofthy commented Mar 19, 2018

One of the things I do with EncFS is use the ENCFS6_CONFIG environment variable to read the config from a different location to the toplevel ".encfs6" file in the encrypted filesystem. That is I don't store the config with the encrypted data. Actually, the config is not even stored in a file but in a secure database along with the decryption password. The env var is used to specify a UNIX named pipe (fifo) which is used to give EncFS the config file. EncFS reads this file, once only, on startup, after which the named pipe is then deleted.

From what I can see GoCryptFS does not even need a config file at all, only the master password to use, which would be ideal. Unfortunately you only provide the ability to give this critical information via the insecure command line! Manpage even mentions how insecure this really is!

Please provide more secure means of passing the master password to GoCryptFS. Either from a file (or named pipe that is read only once), or from a file descriptor (such as STDIN).

OR... Provide the means to read the "gocryptfs.conf" from a user specified file (or pipeline), in the same way that EncFS does. The Manpage lists no such options, or Environment Variables, to do this.

@rfjakob
Copy link
Owner

rfjakob commented Mar 19, 2018

@antofthy
Copy link
Author

antofthy commented Mar 20, 2018 via email

@charles-dyfis-net
Copy link
Contributor

Insofar as the config file can be a named pipe, /dev/fd/... link, &c., I'm hard-pressed to see how it's less secure than other methods.

@antofthy
Copy link
Author

antofthy commented Mar 20, 2018 via email

@rfjakob
Copy link
Owner

rfjakob commented Mar 20, 2018

The problem is this: There's lots of settings that gocryptfs reads from the config file (list). When you mount with "-masterkey", all the settings stay at their default value. So when a new gocryptfs version comes along with changed defaults (added features), your mounts will stop working.

rfjakob added a commit that referenced this issue Mar 21, 2018
@rfjakob
Copy link
Owner

rfjakob commented Mar 21, 2018

You can now let gocryptfs read the masterkey from stdin by passing -masterkey=stdin, commit: 9bc039a

@antofthy
Copy link
Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants