Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing check for plaintextnames in many FUSE callbacks #174

Closed
slackner opened this issue Nov 25, 2017 · 5 comments
Closed

Missing check for plaintextnames in many FUSE callbacks #174

slackner opened this issue Nov 25, 2017 · 5 comments

Comments

@slackner
Copy link
Contributor

Steps to reproduce:

  1. Create a regular GoCryptFS mount point in forward mode and with -plaintextnames
  2. In the mount point directory try to run touch gocryptfs.longname.XXX

This fails with the error No such file or directory, but should actually succeed. The problem is that many FUSE calls do not explicitly check if plaintextnames is set.

@slackner
Copy link
Contributor Author

slackner commented Nov 26, 2017

On the first sight this affects the following functions:

  • Create
  • Mknod
  • Unlink
  • Rename
  • Link

slackner added a commit to slackner/gocryptfs that referenced this issue Nov 28, 2017
In PlaintextNames mode the "gocryptfs.longname." prefix does not have any
special meaning. We should not attempt to read the directory IV or to
create special .name files.

Partially fixes rfjakob#174
slackner added a commit to slackner/gocryptfs that referenced this issue Nov 28, 2017
In PlaintextNames mode the "gocryptfs.longname." prefix does not have any
special meaning. We should not attempt to delete any .name files.

Partially fixes rfjakob#174
slackner added a commit to slackner/gocryptfs that referenced this issue Nov 28, 2017
In PlaintextNames mode the "gocryptfs.longname." prefix does not have any
special meaning. We should not attempt to delete any .name files.

Partially fixes rfjakob#174
rfjakob pushed a commit that referenced this issue Nov 28, 2017
In PlaintextNames mode the "gocryptfs.longname." prefix does not have any
special meaning. We should not attempt to delete any .name files.

Partially fixes #174
@slackner
Copy link
Contributor Author

I fear this one was closed a bit too early. Mknod and Unlink are fixed now, but there might be three other functions affected by the same problem. Should I open new bugs for them?

@rfjakob
Copy link
Owner

rfjakob commented Nov 28, 2017 via email

@slackner
Copy link
Contributor Author

I would, but apparently I don't have permission to reopen myself.

@rfjakob rfjakob reopened this Nov 28, 2017
@rfjakob
Copy link
Owner

rfjakob commented Nov 28, 2017

Hmm will check if i can allow that somehow

slackner added a commit to slackner/gocryptfs that referenced this issue Dec 12, 2017
In PlaintextNames mode the "gocryptfs.longname." prefix does not have any
special meaning.

rfjakob#174
rfjakob pushed a commit that referenced this issue Dec 25, 2017
In PlaintextNames mode the "gocryptfs.longname." prefix does not have any
special meaning.

#174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants