Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider vendoring dependencies #142

Closed
vgough opened this issue Sep 5, 2017 · 2 comments
Closed

Consider vendoring dependencies #142

vgough opened this issue Sep 5, 2017 · 2 comments

Comments

@vgough
Copy link
Contributor

vgough commented Sep 5, 2017

Eg using dep: https://github.com/golang/dep

I just tried to build gocryptfs, but get an incompatibility with go-fuse:

 ./build.bash 
# github.com/rfjakob/gocryptfs/internal/syscallcompat
internal/syscallcompat/getdents_linux.go:94:7: unknown field 'Ino' in struct literal of type fuse.DirEntry

The latest release of github.com/hanwen/go-fuse does not contain Ino, so this means we need a non-release version. Would be preferable, IMO, to have the dependencies vendored so that we can be sure of compatibility.

rfjakob added a commit that referenced this issue Sep 6, 2017
Allows users to get a reproduceable build. Still needs to
be integrated into build.bash.

Suggested at #142
@rfjakob
Copy link
Owner

rfjakob commented Sep 6, 2017

Good point. Reproducing a build is pretty hard right now. I have added the toml files and will integrate "dep" in build.bash once it is merged into the toolchain (should be Go 1.10?)

@rfjakob
Copy link
Owner

rfjakob commented Nov 1, 2017

Fixed by:
(1) Adding Gopkg.lock and Gopkg.toml so users can run "dep ensure" on a git checkout
(2) Releasing a source tarball from v1.4.2 on that includes all dependencies . First tarball: https://github.com/rfjakob/gocryptfs/releases/tag/v1.4.2

@rfjakob rfjakob closed this as completed Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants