Skip to content

Commit

Permalink
Add more optional
Browse files Browse the repository at this point in the history
  • Loading branch information
AnandInguva committed Feb 22, 2023
1 parent 35631f5 commit 3801c16
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,7 @@ message StateGetRequest {
//
// If unspecified, signals to the runner that the response should start
// from the beginning of the logical continuable stream.
bytes continuation_token = 1;
optional bytes continuation_token = 1;
}

// A response to get state representing a logical byte stream which can be
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,11 @@ message PTransform {
// there is none, it may be omitted.
repeated DisplayData display_data = 6;

// Environment where the current PTransform should be executed in.
// (Optional) Environment where the current PTransform should be executed in.
//
// Transforms that are required to be implemented by a runner must omit this.
// All other transforms are required to specify this.
string environment_id = 7;
optional string environment_id = 7;

// (Optional) A map from URNs designating a type of annotation, to the
// annotation in binary format. For example, an annotation could indicate
Expand Down Expand Up @@ -749,19 +749,19 @@ message WriteFilesPayload {
// proto if with_attributes == true. Otherwise, the bytes is the raw payload.
message PubSubReadPayload {

// Topic to read from. Exactly one of topic or subscription should be set.
// (Optional) Topic to read from. Exactly one of topic or subscription should be set.
// Topic format is: /topics/project_id/subscription_name
string topic = 1;
optional string topic = 1;

// Subscription to read from. Exactly one of topic or subscription should be set.
// (Optional) Subscription to read from. Exactly one of topic or subscription should be set.
// Subscription format is: /subscriptions/project_id/subscription_name
string subscription = 2;
optional string subscription = 2;

// Attribute that provides element timestamps.
string timestamp_attribute = 3;
// (Optional) Attribute that provides element timestamps.
optional string timestamp_attribute = 3;

// Attribute to be used for uniquely identifying messages.
string id_attribute = 4;
// (Optional) Attribute to be used for uniquely identifying messages.
optional string id_attribute = 4;

// If true, reads Pub/Sub payload as well as attributes. If false, reads only the payload.
bool with_attributes = 5;
Expand All @@ -786,11 +786,11 @@ message PubSubWritePayload {
// Topic format is: /topics/project_id/subscription_name
string topic = 1;

// Attribute that provides element timestamps.
string timestamp_attribute = 2;
// (Optional) Attribute that provides element timestamps.
optional string timestamp_attribute = 2;

// Attribute that uniquely identify messages.
string id_attribute = 3;
// (Optional) Attribute that uniquely identify messages.
optional string id_attribute = 3;

// If set, the topic is expected to be provided during runtime.
string topic_runtime_overridden = 4;
Expand Down Expand Up @@ -1540,7 +1540,7 @@ message Environment {

// (Optional) The data specifying any parameters to the URN. If
// the URN does not require any arguments, this may be omitted.
bytes payload = 3;
optional bytes payload = 3;

// (Optional) Static display data for the environment. If there is none,
// it may be omitted.
Expand Down

0 comments on commit 3801c16

Please sign in to comment.