Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backmerge to develop #3

Open
wants to merge 54 commits into
base: develop
Choose a base branch
from
Open

backmerge to develop #3

wants to merge 54 commits into from

Conversation

CurtisVonRubenhoff
Copy link
Collaborator

connects to #[issue number]

Description:

Reviewer don't-forgets:

  • Test coverage feels appropriate, given potential risk
  • We're not doubling down on already-bad code
  • If there are web UI changes, they don't add anything that could be considered client-side page navigation (unless pre-approved as being necessary by another engineer)
  • If there are web UI changes, they don't add any AJAX form submits (unless pre-approved as being necessary by another engineer)
  • If there are any lint rules disabled, they are disabled per-line, and were (in the reviewer's judgment) appropriate to disable
  • Any new environment variables used in the app are both documented and have been added to both staging and production environments already
  • Potential race conditions are either inconsequential, or the code prevents them from occurring.
  • If this is a UI change that called for screenshots/GIFs, in the reviewer's judgement, they were included

Joel Wietelmann and others added 24 commits May 29, 2020 11:12
Backend search + wiring up API endpoint for finding proximate locations
Positive Location Submission API endpoint
…tions

start to simplify positive locations
…tions

a more sensible submission response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants