Store extended font configuration in backwards-compatible way #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, due to a bug in the font configuration data reader, downgrading to the release version of Columns UI was causing incorrect custom font sizes to be read. This reworks how the font configuration data is written so that things remain backwards compatible with the release version of Columns UI. Note that the extended DirectWrite-specific font configuration data written by recent development versions of Columns UI won't be read by this version due to the change in how the configuration data is written (and therefore font configuration will be reimported from the old GDI-based configuration structures).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, due to a bug in the font configuration data reader, downgrading to the release version of Columns UI was causing incorrect custom font sizes to be read.
This reworks how the font configuration data is written so that things remain backwards compatible with the release version of Columns UI.
Note that the extended DirectWrite-specific font configuration data written by recent development versions of Columns UI won't be read by this version due to the change in how the configuration data is written (and therefore font configuration will be reimported from the old GDI-based configuration structures).