-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use DirectWrite to render text in the status bar #897
Conversation
A couple of observations:
|
Thanks @marc2k3 .
Thanks, I'll have a look at that.
Thanks, the exception is a small bug when the playlist lock section is shown though doing something more useful with a size of 0 will also need doing... I probably need a better font picker really (since the current one doesn't really expose all the functionality available). As an aside, I wouldn't be surprised if someone doesn't like the switch to DirectWrite but alas I don't really want two different ways of rendering text. I noticed it also doesn't seem to be affected by the system font smoothing or ClearType settings also so I may need to see what can be done about that... |
This makes the status bar use DirectWrite to render text rather than a mix of Uniscribe and GDI. This brings improved text rendering, including sub-pixel positioning and improved handling of colour changes. This includes colour font support on Windows 8.1 and newer.
2373afb
to
961ab9c
Compare
Those two points are hopefully addressed now. |
What does it look like in the release version? I tried to emulate the existing behaviour (and also, the status bar doesn't seem to scale with the font size at 100% DPI, but it does at other DPIs...) |
Interesting size 0 still looks bigger for you with DirectWrite (the difference is marginal for me at 100% DPI...) Anyway, this'll do for now (they'll still be plenty of time for people to give feedback 😄) |
#15
This makes the status bar use DirectWrite to render text rather than a mix of Uniscribe and GDI.
This brings improved text rendering, including sub-pixel positioning and improved handling of colour changes.
This includes colour font support on Windows 8.1 and newer.