Fix GDI-object leak in Item properties dialogue box #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression caused by #683 on older versions of Windows, where the Item properties options tree view state image list was being leaked every time the dialogue was closed. This is linked to the use of the TVS_CHECKBOXES style. This change destroys the image list as directed in the documentation. I was only able to reproduce the leak on older versions of Windows (e.g. Windows 7). (The FCL import and export dialogues already had the logic to destroy the image list, so weren't affected by this problem.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression caused by #683 on older versions of Windows, where the Item properties options tree view state image list was being leaked every time the dialogue was closed. This is linked to the use of the TVS_CHECKBOXES style.
This change destroys the image list as directed in the documentation. I was only able to reproduce the leak on older versions of Windows (e.g. Windows 7).
(The FCL import and export dialogues already had the logic to destroy the image list, so weren't affected by this problem.)