Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework buttons options dialogue box layout #689

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

reupen
Copy link
Owner

@reupen reupen commented Apr 2, 2023

This makes various changes to the layout of the buttons options dialogue box in preparation for dark mode support.

This includes removing the tabs and group box.

Some dead code following other recent dark mode dialogue box changes was also removed.

@reupen reupen force-pushed the dark-mode-buttons-opts-pt-1 branch 4 times, most recently from ee14130 to 3bd7b2d Compare April 2, 2023 18:48
This makes various changes to the layout of the buttons options dialogue box in preparation for dark mode support.

This includes removing the tabs and group box.
This removes various bits of dead code in various dialogue boxes that was being used to paint their backgrounds. This is no longer needed as it is now handled by the dark mode helpers.
@reupen reupen force-pushed the dark-mode-buttons-opts-pt-1 branch from 3bd7b2d to eb80a0b Compare April 2, 2023 18:57
@reupen reupen marked this pull request as ready for review April 3, 2023 18:38
@reupen reupen merged commit a29fa07 into master Apr 3, 2023
@reupen reupen deleted the dark-mode-buttons-opts-pt-1 branch April 3, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant