Use SVGs for non-standard icon sizes when possible #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reorganises icons files in preparation for support for using SVGs for the default icons.
As it avoids needing to render text, and ensure consistent rendering.
For consistency with other objects in the SVG documents.
reupen
force-pushed
the
svg-default-icons
branch
2 times, most recently
from
e2970f1
to
207fe6b
Compare
This renders built-in icons using SVGs if: - the display size isn't a size in the corresponding icon resource; and - the SVG services component is installed This improves display quality in such cases, as otherwise one of the existing sizes in the icon resource will be scaled. Pre-rendered icons are still preferred for standard sizes, as they are slightly better quality than what is obtained by rendering the SVG using SVG services. Standard sizes are square icons that are 16, 20, 24, 28, 32, 36, 40, 48, 56, 64 or 256 pixels in width and height. This change also includes various bits of related refactoring.
reupen
force-pushed
the
svg-default-icons
branch
from
207fe6b
to
5c533a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renders built-in icons using SVGs if:
This improves display quality in such cases, as otherwise one of the existing sizes in the icon resource will be scaled.
Pre-rendered icons are still preferred for standard sizes, as they are slightly better quality than what is obtained by rendering the SVG using SVG services.
Standard sizes are square icons that are 16, 20, 24, 28, 32, 36, 40, 48, 56, 64 or 256 pixels in width and height.
This change also includes various bits of related refactoring.