Optimise typing in playlist view to jump to items in foobar2000 2.0 #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reupen
force-pushed
the
optimise-playlist-view-search-2-0
branch
from
fe579ae
to
d58cda5
Compare
This changes how typing in the playlist view to jump to items works in foobar2000 2.0 to improve performance. Previously, it formatted tracks and columns individually, including style scripts, where this information wasn't already cached. Now, it formats tracks in large batches, and only formats the display script for the first column. This performs better in foobar2000 2.0. There is also no longer any long-term caching involved.
reupen
force-pushed
the
optimise-playlist-view-search-2-0
branch
from
d58cda5
to
04b7ba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #602
This changes how typing in the playlist view to jump to items works in foobar2000 2.0 to improve performance.
Previously, it formatted tracks and columns individually, including style scripts, where this information wasn't already cached.
Now, it formats tracks in large batches, and only formats the display script for the first column. This performs better in foobar2000 2.0. There is also no longer any long-term caching involved.