Improve Item details scroll bar handling #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reupen
force-pushed
the
improve-item-details-scroll-bar-handling
branch
from
cf9674e
to
e392541
Compare
Fixes #331 This rewrites scroll bar-related code in Item details in an effort to improve behaviour when scroll bar information is updated, and fix a problem where it sometimes wasn't possible to scroll to the very bottom if both scroll bars were visible. This also attempts to preserve the scroll position when changing settings.
reupen
force-pushed
the
improve-item-details-scroll-bar-handling
branch
from
e392541
to
f597937
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #331
This rewrites scroll bar-related code in Item details in an effort to improve behaviour when scroll bar information is updated, and fix a problem where it sometimes wasn't possible to scroll to the very bottom if both scroll bars were visible.
This also attempts to preserve the scroll position when changing settings.