Fix stale panel data being copied when copying panels in live editing #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes bugs in the standard splitter panels that caused stale panel configuration data to be copied when a panel was copy and pasted in live editing.
reupen
force-pushed
the
bugfix/copy-panel
branch
from
d7f4a6b
to
41828a3
Compare
reupen
added a commit
that referenced
this pull request
Mar 28, 2021
This reworks the changes that were made in #320 so that the standard splitters no longer refresh a panel's configuration data when `splitter_window::get_panel()` is called. This is to avoid panel configuration data being unnecessarily queried at strange moments (e.g. when the main window becomes inactive). Instead, a refresh is done when a panel is being copied, which still fixes the original problem of stale configuration data being copied when a panel is copied during live editing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bugs in the standard splitter panels that caused stale panel configuration data to be copied when a panel was copy and pasted in live editing.