Fix various inline editing bugs in the playlist view #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a crash when using inline editing and setting a field value to an empty string.
This changes the behaviour of inline editing in the playlist view so that empty field values are not added to files when saving changes.
reupen
force-pushed
the
fix-inline-editing-empty-string
branch
from
4d4bf64
to
28f6d41
Compare
This fixes a crash when saving changes after using inline editing in the playlist view on more than two files with differing field values. A side effect of the fix is that inline editing is no longer sometimes blocked if a file with no loaded metadata is encountered; this will instead (probably) fail at saving time.
reupen
force-pushed
the
fix-inline-editing-empty-string
branch
from
28f6d41
to
65c853c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various problems with inline metadata editing in the playlist view:
The behaviour is also changed slightly when encountering files with no loaded metadata – it will always let you attempt to update the file (though this will may well fail).