Improve Item properties performance #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This significantly improves performance when refreshing the contents of the Item properties panel for large selections. Refresh times can be as little as 20% of the time taken prior to these changes. This results in a general UI responsiveness improvement, in particular when using library viewers. Improvements were made partly by removing unneeded processing, and partly by using parallelism. As a result of these changes, metadata field values are no longer sorted (which was already inconsistent with the rest of foobar2000). The sort order of track property sections was also corrected.
reupen
force-pushed
the
improve-item-props-perf
branch
from
39fdb8d
to
c59b9bc
Compare
reupen
added a commit
that referenced
this pull request
Aug 4, 2019
This was a result of the changes in #199. `track_property_provider_v3` expects provided `metadb_info_container` objects to be non-null and there is a subtle difference in behaviour between the `metadb_handle::get_info_ref()` overloads. Now, invalid `metadb_info_container::ptr` objects are avoided completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly improves performance when refreshing the contents of the Item properties panel for large selections.
Refresh times can be as little as 20% of the time taken prior to these changes. This results in a general UI responsiveness improvement, in particular when using library viewers.
Improvements were made partly by removing unneeded processing, and partly by using parallelism.
As a result of these changes, metadata field values are no longer sorted (which was already inconsistent with the rest of foobar2000).
The sort order of track property sections was also corrected.