Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in artworkview for stub images? #314

Closed
ASopH opened this issue May 15, 2020 · 1 comment · Fixed by #345
Closed

Bug in artworkview for stub images? #314

ASopH opened this issue May 15, 2020 · 1 comment · Fixed by #345

Comments

@ASopH
Copy link

ASopH commented May 15, 2020

Hello :)

I entered different images for missing pictures of front, back, artist and disc. Unfortunately, only the picture for front is displayed when one or more image for the other types are missing.

I've tested the same pictures in DUI and there is all ok.

Many thanks and stay healthy!
@reupen
Copy link
Owner

reupen commented May 16, 2020

Hi,

Thanks for the report. Indeed, there's a comment to that effect in the source:

columns_ui/foo_ui_columns/artwork_helpers.cpp

Line 273 in 6276a1a

// FIXME: We are always using the front no cover image

It shouldn't be too hard to fix – I'll have a look when I have a chance.

Thanks

reupen added a commit that referenced this issue Oct 2, 2020
@reupen
Add support for non-front cover stub images to artwork view
903c1c7 
Fixes #314

This adds support for back cover, disc and artist stub images to the artwork view.

These are configured on the main Display page in preferences.

The front cover stub image is used as a fallback if any of these three stub images fail to load (e.g. due to not being configured).
@reupen reupen mentioned this issue Oct 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Columns UI
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for non-front cover stub images to artwork view reupen/columns_ui
2 participants
@reupen @ASopH