Make __title__ optional #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many cases, the registered PyPI name will be the same as package/module name, and we will usually be able to construct that from the passed path. This commit fills in the path-based value as a default, so users who do set __title__ explicitly will be able to clobber that default with their custom value.
Owner
|
I like this patch, but to prove it doesn't break anything, you mind editing the test to remove |
Personally, I prefer the explicit __title__ in this case, because: * It shows how you'd set __title__ if you wanted to, and * The random name from the temporary file is probably not a great title. But Reuben wants this for testing the new code [1], so here it is ;). [1]: reubano#2 (comment)
Contributor
Author
I've pushed 5e88b7c with that change, but it's a bit awkward for the randomly-named test module. I'm fine with or without the doctest commit. |
wking
commented
Jun 27, 2018
| ... module = parse_module(f.name) | ||
| ... module.__version__ == '0.12.4' | ||
| ... module.__title__ == module.get('__title__') == 'pkutils' | ||
| ... module.__title__ == os.path.splitext(os.path.basename(f.name))[0] |
Contributor
Author
There was a problem hiding this comment.
Looks like I made this line too long for lint. @reubano, it's probably easier for you to fix that directly, but I can file a fixup PR if it would help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases, the registered PyPI name will be the same as package/module name, and we will usually be able to construct that from the passed path. This commit fills in the path-based value as a default, so users who do set
__title__explicitly will be able to clobber that default with their custom value.