Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate --import flag for CI steps #377

Closed
rsubtil opened this issue Apr 10, 2024 · 1 comment · Fixed by #376
Closed

Investigate --import flag for CI steps #377

rsubtil opened this issue Apr 10, 2024 · 1 comment · Fixed by #376
Labels
enhancement New feature or request topic:ci Issues or pull requests regarding CI

Comments

@rsubtil
Copy link
Member

rsubtil commented Apr 10, 2024

godotengine/godot#90431 adds a new CLI flag to ensure Godot imports the project before attempting to export it. This is needed as otherwise a lot of script/asset errors occur, and the final build is broken.

However, this would imply having to compile a custom editor build just to take advantage of it. For now we are using the timeout hack, but when this makes into a public build, we can switch to the new version.

@rsubtil rsubtil added enhancement New feature or request topic:ci Issues or pull requests regarding CI labels Apr 10, 2024
@rsubtil
Copy link
Member Author

rsubtil commented Apr 10, 2024

Also would be a good idea to check if this import step is indeed the root cause of #245.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic:ci Issues or pull requests regarding CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant