Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darken-blur background not working on exported versions #245

Open
rsubtil opened this issue Jul 22, 2023 · 4 comments · Fixed by #258
Open

Darken-blur background not working on exported versions #245

rsubtil opened this issue Jul 22, 2023 · 4 comments · Fixed by #258
Labels
bug Something isn't working topic:core Issues or pull requests related to RetroHub itself

Comments

@rsubtil
Copy link
Member

rsubtil commented Jul 22, 2023

The darkening-blur background is not working on the exported version for some reason (works from editor):
image
@rsubtil rsubtil added bug Something isn't working topic:core Issues or pull requests related to RetroHub itself labels Jul 22, 2023
@rsubtil rsubtil added this to the v0.2.0 milestone Jul 22, 2023
@rsubtil
Copy link
Member Author

rsubtil commented Jul 24, 2023

Shader parameters appear to not be set on export releases, not sure if this is a bug on the engine.

@rsubtil rsubtil mentioned this issue Aug 4, 2023
Merged
@rsubtil
Copy link
Member Author

rsubtil commented Aug 18, 2023

This is actually happening globally on any exported variable, as default values on theme nodes are not used. This should be investigated better, as it definitely is a Godot bug.

@rsubtil rsubtil reopened this Aug 18, 2023
@rsubtil rsubtil removed this from the v0.2.0 milestone Sep 2, 2023
@rsubtil rsubtil added this to the v1.0.0 milestone Oct 2, 2023
@rsubtil rsubtil mentioned this issue Oct 8, 2023
Closed
@rsubtil rsubtil removed this from the v1.0.0 milestone Oct 15, 2023
@rsubtil rsubtil mentioned this issue Apr 10, 2024
Closed
@rsubtil
Copy link
Member Author

rsubtil commented Apr 13, 2024

#377 and #376 will be merged soon, and it seems to be related to this. This should be tested to check if it remains an issue then.

@rsubtil
Copy link
Member Author

rsubtil commented Apr 13, 2024

Sadly these new PRs haven't fixed it either (#379). Definitely needs to be investigated for what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working topic:core Issues or pull requests related to RetroHub itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix black blur background retrohub-org/retrohub
Restore shader parameters retrohub-org/retrohub
1 participant
@rsubtil