Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React Native 0.68 #8

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Update to React Native 0.68 #8

merged 2 commits into from
Feb 10, 2022

Conversation

retrixe
Copy link
Owner

@retrixe retrixe commented Feb 8, 2022

Before merging:

  • Fix build issue with react-native-tcp.
  • Look into enabling new architectural features (Fabric and TurboModules).

@retrixe
Copy link
Owner Author

retrixe commented Feb 10, 2022

Editing react-native-tcp's android/build.gradle like so fixes the build issue:

repositories {
    maven {
        // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
        url "$projectDir/../node_modules/react-native/android"
    }
    mavenCentral()
}

dependencies {
    implementation 'com.facebook.react:react-native:+'
    implementation 'com.koushikdutta.async:androidasync:2.1.6'
}

EDIT: Looks like this is patched out of the box in the latest version of react-native-tcp.

As for enabling New Architecture, it just depends on the sizable Android NDK, causes node_modules/react-native/ReactAndroid/build to swell massively, and doesn't deliver any improvements at the moment, so this is on the backburner.

@retrixe retrixe merged commit e7311e1 into main Feb 10, 2022
@retrixe retrixe deleted the feat/rn-0.68 branch February 10, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant