Fit beta #11
Closed
Fit beta #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, glue code missing. See the danger/README.md file for more details. Also I have no idea if just adding a module to requirements.txt is something you can do just like that.
I was just checking if the README.md would render correctly
|
Hm thanks for this implementation but I think ideally we can fit the beta in Python and not need to have the package make API calls. I fixed the typo (thanks for that) f65eec4 but I'm going to close this PR and focus on porting over the Beta logic instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates functionality from https://nunosempere.com/blog/2023/03/15/fit-beta/ in Python. But glue code to integrate with Squigglepy is missing.
Also fixes a typo, Monte Hall => Monty Hall.