replace current websocket implementation with engine.io, made tests work in node without mocking window #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork in node without mocking window
|
@flipace can you add me as a collaborator on your repo? |
|
Done!
|
| // .close is called from the client (see closeSocket), this | ||
| // listener will be removed | ||
| statusSubject.next(STATUS_DISCONNECTED) | ||
| if (e.code !== 1000 || !e.wasClean) { |
There was a problem hiding this comment.
This is the bug that causes the issue. engine.io doesn't return an error object with e.code and e.wasClean defined, it's just a string. So this should be something like:
if (e !== 'forced close') {
... ${e}), e)
} else {
...
}'forced close' is the close reason returned when the user calls .close on the socket
|
Ok, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 tests fail atm