Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/RestSharp/RestClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,8 @@ internal static void ConfigureHttpMessageHandler(HttpClientHandler handler, Rest
if (!OperatingSystem.IsBrowser()) {
#endif
handler.UseCookies = false;
handler.Credentials = options.Credentials;
handler.UseDefaultCredentials = options.UseDefaultCredentials;
handler.UseDefaultCredentials = options.UseDefaultCredentials;
if (options.Credentials != null) handler.Credentials = options.Credentials;
handler.AutomaticDecompression = options.AutomaticDecompression;
handler.PreAuthenticate = options.PreAuthenticate;
if (options.MaxRedirects.HasValue) handler.MaxAutomaticRedirections = options.MaxRedirects.Value;
Expand Down
44 changes: 44 additions & 0 deletions test/RestSharp.Tests/CredentialConfigurationTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
using System.Net;

namespace RestSharp.Tests;

public class CredentialConfigurationTests {
[Fact]
public void Explicit_credentials_are_not_overwritten_by_UseDefaultCredentials() {
var credentials = new NetworkCredential("user", "password");
var options = new RestClientOptions("https://dummy.org") {
Credentials = credentials,
UseDefaultCredentials = false
};

var handler = new HttpClientHandler();
RestClient.ConfigureHttpMessageHandler(handler, options);

handler.Credentials.Should().BeSameAs(credentials);
}

[Fact]
public void DefaultCredentials_set_explicitly_are_not_overwritten() {
var options = new RestClientOptions("https://dummy.org") {
Credentials = CredentialCache.DefaultCredentials,
UseDefaultCredentials = false
};

var handler = new HttpClientHandler();
RestClient.ConfigureHttpMessageHandler(handler, options);

handler.Credentials.Should().BeSameAs(CredentialCache.DefaultCredentials);
}

[Fact]
public void UseDefaultCredentials_sets_credentials_when_no_explicit_credentials() {
var options = new RestClientOptions("https://dummy.org") {
UseDefaultCredentials = true
};

var handler = new HttpClientHandler();
RestClient.ConfigureHttpMessageHandler(handler, options);

handler.UseDefaultCredentials.Should().BeTrue();
}
}
Loading