Skip to content

JsonSerializer does not respect Culture when deserializing primitive types #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeyzimarev merged 1 commit into from
Jul 15, 2021
Merged

JsonSerializer does not respect Culture when deserializing primitive types #1606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/RestSharp/Extensions/ReflectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ public static bool IsSubclassOfRawGeneric(this Type toCheck, Type generic)
return false;
}

internal static object ChangeType(this object source, Type newType, IFormatProvider provider) => Convert.ChangeType(source, newType, provider);

internal static object ChangeType(this object source, Type newType) => Convert.ChangeType(source, newType);

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/RestSharp/Serializers/Json/JsonSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ object ConvertValue(TypeInfo typeInfo, object value)
}

var type = typeInfo.AsType();
if (typeInfo.IsPrimitive) return value.ChangeType(type);
if (typeInfo.IsPrimitive) return value.ChangeType(type, Culture);

if (typeInfo.IsEnum) return type.FindEnumValue(stringValue, Culture);

Expand Down