Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gethostbyaddr deprecation warnings #753

Merged

Conversation

irvingreid
Copy link
Contributor

Use supported Addrinfo APIs to get the fully qualified local host name.

@irvingreid
Copy link
Contributor Author

After a fair bit of local debugging, I suspect this test failure is flaky? I could only reproduce it when I had another instance of resque-scheduler attached to my Redis server.

@PatrickTulskie
Copy link
Contributor

Hey I think this is probably okay to sneak into a patch release. Would you mind removing the gemspec changes? The gemspec changes aren't required for this fix.

@irvingreid irvingreid force-pushed the fix-gethostbyaddr-deprecation branch from bdc5caf to 5e8953b Compare October 7, 2022 04:37
@irvingreid
Copy link
Contributor Author

Would you mind removing the gemspec changes? The gemspec changes aren't required for this fix.

@PatrickTulskie done, thanks for reviewing!

@PatrickTulskie
Copy link
Contributor

Hey it looks like those commits are still in this branch. Can you remove the out of scope commits instead of just reverting them? I can also do a merge but the rebase with a single clean commit is better. Gonna aim to get in a point release next week.

@irvingreid
Copy link
Contributor Author

Ah OK. We usually do squash merges here, so we don't fuss about the branch being noisy :-)

@irvingreid
Copy link
Contributor Author

Sorry about the delay - I got tricked by Github not syncing the upstream and origin master branches quite the way I expected, and couldn't figure out why the test was failing (and couldn't figure out how to re-run that one test case without pushing a change - is that possible with this CI setup?)

@oehlschl
Copy link

@PatrickTulskie looks like this should be good to go now -- one commit as requested, and checks are passing. Can you please add this to a coming release for Ruby 3 compatibility?

@PatrickTulskie PatrickTulskie self-assigned this Jan 22, 2023
@PatrickTulskie
Copy link
Contributor

Sorry about the delay merging this. Was dealing with an end of quarter crunch. Anyhow, it's in gem v4.8.0 shipped just now.

@irvingreid irvingreid deleted the fix-gethostbyaddr-deprecation branch January 27, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants