Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflected Cross Site Scripting in Resque Scheduler #761

Closed
trung512 opened this issue Oct 21, 2022 · 5 comments
Closed

Reflected Cross Site Scripting in Resque Scheduler #761

trung512 opened this issue Oct 21, 2022 · 5 comments

Comments

@trung512
Copy link

Exploit Title: Reflected Cross Site Scripting in Resque Scheduler

Date: 21/10/2022

Exploit Author: Trungvm of VietSunshine Cyber Security Services

Vendor Homepage: http://resque.github.io/

Tested version: v1.27.4

Description:

Resque Scheduler version 1.27.4 is affected by an Cross-site scripting vulnerability. A remote attacker could inject javascript code to the "{schedule_job}" or "args" parameter in /resque/delayed/jobs/{schedule_job}?args={args_id} to execute javascript at client side.

Steps to reproduce:

An attacker sends a draft URL https://[IP]/resque/delayed/jobs/{schedule_job}?args={args_id} to a victim. When an authenticated victim opens a URL, XSS will be triggered.

Payload example:

Ex1: https://[IP]/resque/delayed/jobs/%3Csvg%20onload=alert(document.domain)
Ex2: https://[IP/resque/delayed/jobs/EventEmailSalesTeamBefore48hrsJob?args=[%2249213%3Cimg+src=x+onerror=alert(document.domain)%3E%22]

POC

Xss_1
Xss_2

@jchristman
Copy link

Tested the Proofs of Concept from above and they work on a minimal, fresh install of Resque and Resque-Scheduler. The problem is not limited to version 1.27.4.

PatrickTulskie added a commit to PatrickTulskie/resque-scheduler that referenced this issue Dec 4, 2023
PatrickTulskie added a commit to PatrickTulskie/resque-scheduler that referenced this issue Dec 15, 2023
@PatrickTulskie
Copy link
Contributor

This is fixed in resque-scheduler 4.10.2

Relevant PRs:
#780
#783

Thank you for reporting. A security advisory should be coming out shortly for this issue.

@nevans
Copy link

nevans commented Dec 18, 2023

@PatrickTulskie Could you double-check the version numbers (both affected and patched) on GHSA-9hmq-fm33-x4xx? They are currently 2.10.x, but I think they should be 4.10.x, right? (Thanks!)

@PatrickTulskie
Copy link
Contributor

@PatrickTulskie Could you double-check the version numbers (both affected and patched) on GHSA-9hmq-fm33-x4xx? They are currently 2.10.x, but I think they should be 4.10.x, right? (Thanks!)

You're 100% right. Thank you for the catch. I just fixed it.

@jchristman
Copy link

Thanks for the patch! Security Advisory is nicely detailed also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants