Some new devices added to devicelist.ts #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
web_dev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
manojVivek
reviewed
Sep 6, 2024
| @@ -870,6 +870,47 @@ export const defaultDevices: Device[] = [ | |||
| isTouchCapable: false, | |||
| isMobileCapable: false, | |||
| }, | |||
| { | |||
| id: '90004', | |||
There was a problem hiding this comment.
Can you please fix the IDs to stick to the guidelines here: https://github.com/responsively-org/responsively-app/pull/1293/files#diff-1f757e572fe35320119d79efc7411be133df8ec132a1737e78a872eaa1720da8R16-R22
manojVivek
reviewed
Sep 6, 2024
desktop-app/src/common/deviceList.ts
Outdated
| type: 'phone', | ||
| isTouchCapable: true, | ||
| isMobileCapable: true, | ||
| }, |
There was a problem hiding this comment.
It would be great if you could run the prettier formatting on this file.
There was a problem hiding this comment.
fixed id and added prettier
manojVivek
approved these changes
Sep 9, 2024
|
@all-contributors Please add @Sukrit-Prakash for code. |
|
I've put up a pull request to add @Sukrit-Prakash! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
ℹ️ About the PR
This PR introduces the following updates to the devicelist.ts:
1.Added support for Galaxy Z Fold 5 with a screen size of 344x882, dpr: 1.
2.Added support for Asus Zenbook Fold with a screen size of 853x1280, dpr: 2.
3.Added support for Pixel 7 with a screen size of 412x915, dpr: 2.625.
Each device entry includes its specific properties like userAgent, capabilities, and device type (phone, tablet).
🖼️ Testing Scenarios / Screenshots
Tested the changes by simulating these devices in the responsive design mode of Google Chrome DevTools.
Verified touch and mobile capabilities for the Galaxy Z Fold 5 and Pixel 7.
Ensured that the Asus Zenbook Fold is categorized as a tablet with the appropriate touch capabilities.