-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cancel e-invoice on cancel of invoice from list view #2668
base: develop
Are you sure you want to change the base?
fix: cancel e-invoice on cancel of invoice from list view #2668
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2668 +/- ##
===========================================
+ Coverage 61.34% 61.37% +0.03%
===========================================
Files 119 119
Lines 11506 11521 +15
===========================================
+ Hits 7058 7071 +13
- Misses 4448 4450 +2
|
@@ -200,6 +201,23 @@ def before_cancel(doc, method=None): | |||
) | |||
|
|||
|
|||
def on_cancel(doc, method=None): | |||
if ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gst settings for cancel with APIs.
Also check if its cancellable before calling cancel APIs
def on_cancel(doc, method=None): | ||
if ( | ||
not doc.irn | ||
or not frappe.form_dict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's restrict this to just list view cancel events.
Possible UX: Select Invoices => Actions => Cancel => evaluate if any invoice has e-Invoice or e-Waybill that is cancellable => if Yes, Pop up for reason of cancellation => Cancel IRN and e-Waybill. Alternatively, option to cancel Invoices without cancelling should be possible as a secondary button.
2a0501c
to
c064abe
Compare
closes: #2662
closes: #2711
Huly®: IC-2792