feat(base): support mts configs #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prescottprue
requested review from
alexsupp,
mathieudi,
hershmire and
tylerzey
and removed request for
a team
hershmire
approved these changes
Oct 10, 2024
| '**/protractor.conf.js', // protractor config | ||
| '**/protractor.conf.*.js', // protractor config | ||
| '**/karma.conf.js', // karma config | ||
| '**/jest.config.{js,ts,mjs,cjs,mts,cts}', // jest config |
There was a problem hiding this comment.
These all support TS extension?
There was a problem hiding this comment.
For jest yeah ts-jest does. I applied the same extensions to all these since it is a common standard and didn't want to miss any
Not positive about committlint, lint-staged, and release but if they don't they may add that capability in the future so figured it was worth having in our lint config
There was a problem hiding this comment.
Roger. I'm good with this for now.
mathieudi
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ TICKET-000
Upstream PRs
Downstream PRs
Changes
mtsandctsfile extensions on config files (specifically vitest)Notes for Reviewers
Recordings/Screenshots