Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base Mainnet deployment #956

Merged
merged 14 commits into from
Oct 2, 2023
Merged

Base Mainnet deployment #956

merged 14 commits into from
Oct 2, 2023

Conversation

julianmrodri
Copy link
Contributor

@julianmrodri julianmrodri commented Sep 28, 2023 •
edited
Loading

Base deployment scripts and addresses (protocol and Plugins)

Also includes deployment of aETHUSDC (Aave V3 USDC) to Mainnet Ethereum.

tbrent
tbrent reviewed Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@tbrent tbrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a few oracleErrors/oracleTimeouts that were off

I also neglected to mention before (my b) that the defaultThreshold should be a function of the oracleError. For fiatcoins it's 0.01 + oracleError and for LSDs its 0.02 + oracleError

scripts/deployment/phase2-assets/2_deploy_collateral.ts Outdated Show resolved Hide resolved
scripts/deployment/phase2-assets/2_deploy_collateral.ts Outdated Show resolved Hide resolved
scripts/deployment/phase2-assets/2_deploy_collateral.ts Outdated Show resolved Hide resolved
scripts/deployment/phase2-assets/2_deploy_collateral.ts Outdated Show resolved Hide resolved
scripts/deployment/phase2-assets/collaterals/deploy_cbeth_collateral.ts Show resolved Hide resolved
scripts/deployment/phase2-assets/collaterals/deploy_ctokenv3_usdbc_collateral.ts Outdated Show resolved Hide resolved
@julianmrodri
Copy link
Contributor Author

found a few oracleErrors/oracleTimeouts that were off

I also neglected to mention before (my b) that the defaultThreshold should be a function of the oracleError. For fiatcoins it's 0.01 + oracleError and for LSDs its 0.02 + oracleError

Implemented all the fixes. I had to redeploy most collaterals due to the defaultThreshold change. Already updated the addresses in the PR.

@tbrent
Copy link
Collaborator

tbrent commented Sep 29, 2023

Awesome, LGTM

@julianmrodri
Copy link
Contributor Author

Can we merge this one?

@julianmrodri julianmrodri merged commit 9014df3 into master Oct 2, 2023
9 checks passed
@julianmrodri julianmrodri deleted the base-deployment branch October 2, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmckelvy1 pmckelvy1 pmckelvy1 left review comments

@tbrent tbrent Awaiting requested review from tbrent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianmrodri @tbrent @pmckelvy1