proposal validator tweaks #4128
Triggered via pull request
January 29, 2025 12:54
julianmrodri
Status
Success
Total duration
1h 6m 33s
Artifacts
–
tests.yml
on: pull_request
Deployment Scripts
9m 27s
Lint Checks
11m 31s
Plugin Unit Tests
10m 54s
Plugin Integration Tests (Mainnet) - 1/3
1h 6m
Plugin Integration Tests (Mainnet) - 2/3
27m 56s
Plugin Integration Tests (Mainnet) - 3/3
41m 4s
Plugin Integration Tests (Base)
29m 41s
Plugin Integration Tests (Arbitrum)
20m 44s
P0 tests
17m 56s
P1 Tests
17m 48s
Scenario Tests
10m 7s
Extreme Tests
49m 1s
Integration Tests
7m 54s
Monitor Tests (Mainnet)
6m 31s
Registry Tests
4m 36s
Annotations
10 warnings
|
Lint Checks:
contracts/facade/Facade.sol#L32
When fallback is not payable you will not be able to receive ether
|
|
Lint Checks:
contracts/facade/Facade.sol#L32
Fallback function must be simple
|
|
Lint Checks:
contracts/facade/Facade.sol#L37
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L47
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L112
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L113
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint Checks:
contracts/p0/AssetRegistry.sol#L128
Code contains empty blocks
|
|
Lint Checks:
contracts/p0/Deployer.sol#L178
Code contains empty blocks
|
|
Lint Checks:
contracts/p1/Broker.sol#L40
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/p1/Main.sol#L158
Avoid to use low level calls
|