feat(webhooks): add signing secret rotation endpoint - #159
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
1 issue found across 6 files
Confidence score: 4/5
- In
src/Resend/WebhookNew.cs, omitting the rotation response’sobjectfield prevents consumers from reading that response metadata; add the[JsonPropertyName("object")]Objectproperty and populate it in the mock response.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/Resend/WebhookNew.cs">
<violation number="1" location="src/Resend/WebhookNew.cs:6">
P2: Consumers cannot access the `object` field from the rotation response. `WebhookNew` exposes only `Id` and `SigningSecret`, so add an `[JsonPropertyName("object")]` `Object` property and populate it in the mock response.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
felipefreitag
approved these changes
Sep 10, 2026
This was referenced Sep 11, 2026
Closed
Closed
This was referenced Sep 18, 2026
Closed
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
WebhookRotateSigningSecretAsync(webhookId)forPOST /webhooks/{webhook_id}/signing-secret/rotate, spec in resend/resend-openapi#113. The response is the same{object, id, signing_secret}shape create webhook returns, so it reusesWebhookNewinstead of adding a type; the mock server and the test follow the same layout as the event replay endpoint (#157). Rollout sub-issue: https://linear.app/resend/issue/DEV-2075🤖 Generated with Claude Code
Summary by cubic
Adds
WebhookRotateSigningSecretAsync(webhookId)to rotate a webhook's signing secret viaPOST /webhooks/{webhook_id}/signing-secret/rotate, resolving DEV-2075.WebhookNewresponse type since the endpoint returns the same shape as webhook creation.Written for commit 94227d4. Summary will update on new commits.