Repository navigation
feat(segments): add SegmentUpdateAsync for PATCH /segments/:id #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dielduarte
merged 2 commits into
main
from
feature/dev-1205-edit-segments-through-the-api
Aug 26, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| using System.Text.Json.Serialization; | ||
|
|
||
| namespace Resend; | ||
|
|
||
| /// <summary> | ||
| /// Result of updating a segment. | ||
| /// </summary> | ||
| public class SegmentUpdateResult | ||
| { | ||
| /// <summary> | ||
| /// Object type discriminator. | ||
| /// </summary> | ||
| [JsonPropertyName( "object" )] | ||
| public string Object { get; set; } = default!; | ||
|
|
||
| /// <summary> | ||
| /// Segment identifier. | ||
| /// </summary> | ||
| [JsonPropertyName( "id" )] | ||
| public Guid Id { get; set; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| namespace Resend.Tests; | ||
|
|
||
| /// <summary /> | ||
| public partial class ResendClientTests | ||
| { | ||
| /// <summary/> | ||
| [Fact] | ||
| public async Task SegmentUpdate() | ||
| { | ||
| var segmentId = Guid.NewGuid(); | ||
|
|
||
| var resp = await _resend.SegmentUpdateAsync( segmentId, new SegmentData() | ||
| { | ||
| Name = "Renamed segment", | ||
| } ); | ||
|
|
||
| Assert.NotNull( resp ); | ||
| Assert.NotNull( resp.Content ); | ||
| Assert.Equal( segmentId, resp.Content.Id ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| using Microsoft.AspNetCore.Mvc; | ||
|
|
||
| namespace Resend.ApiServer.Controllers; | ||
|
|
||
| /// <summary /> | ||
| [ApiController] | ||
| public class SegmentController : ControllerBase | ||
| { | ||
| private readonly ILogger<SegmentController> _logger; | ||
|
|
||
|
|
||
| /// <summary /> | ||
| public SegmentController( ILogger<SegmentController> logger ) | ||
| { | ||
| _logger = logger; | ||
| } | ||
|
|
||
|
|
||
| /// <summary /> | ||
| [HttpPatch] | ||
| [Route( "segments/{id}" )] | ||
| public SegmentUpdateResult SegmentUpdate( [FromRoute] Guid id, [FromBody] SegmentData data ) | ||
| { | ||
| _logger.LogDebug( "SegmentUpdate" ); | ||
|
|
||
| return new SegmentUpdateResult() | ||
| { | ||
| Object = "segment", | ||
| Id = id, | ||
| }; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| using McMaster.Extensions.CommandLineUtils; | ||
| using System.ComponentModel.DataAnnotations; | ||
|
|
||
| namespace Resend.Cli.Segment; | ||
|
|
||
| /// <summary /> | ||
| [Command( "update", Description = "Update a segment" )] | ||
| public class SegmentUpdateCommand | ||
| { | ||
| private readonly IResend _resend; | ||
|
|
||
| /// <summary /> | ||
| [Argument( 0, Description = "Segment identifier" )] | ||
| [Required] | ||
| public Guid? SegmentId { get; set; } | ||
|
|
||
| /// <summary /> | ||
| [Argument( 1, Description = "Segment name" )] | ||
| [Required] | ||
| public string? Name { get; set; } | ||
|
|
||
|
|
||
| /// <summary /> | ||
| public SegmentUpdateCommand( IResend resend ) | ||
| { | ||
| _resend = resend; | ||
| } | ||
|
|
||
|
|
||
| /// <summary /> | ||
| public async Task<int> OnExecuteAsync() | ||
| { | ||
| var data = new SegmentData() | ||
| { | ||
| Name = this.Name!, | ||
| }; | ||
|
|
||
| await _resend.SegmentUpdateAsync( this.SegmentId!.Value, data ); | ||
|
|
||
| return 0; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's maybe not update the CLI? we've already deprecated it anyway, we don't need to update it