feat: add EmailShareAsync method - #142
Merged
Merged
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
dielduarte
force-pushed
the
share-email-link
branch
from
August 20, 2026 14:27
d3dbca2 to
f2f3aee
Compare
dielduarte
marked this pull request as ready for review
August 20, 2026 15:07
felipefreitag
approved these changes
Aug 20, 2026
…server The test fixture doesn't need to parse durations like the real API -- it only needs to return realistic responses for the fixed set of inputs the test suite exercises. Replaces the regex-based parser with a plain allow-list.
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Adds a net-new EmailShareAsync API, including a public interface method that breaks existing IResend implementers and new public DTOs — a public contract change needing human sign-off.
Re-trigger cubic
3 tasks
This was referenced Aug 21, 2026
This was referenced Aug 28, 2026
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
EmailShareAsync(Guid emailId, string? expiresIn = null, ...), calling the newPOST /emails/{id}/shareendpoint that creates a shareable link for a sent or received email. See the spec PR resend/resend-openapi#92.expiresInis an optional human-readable duration (e.g.10m,2 hours,1 day; server defaults to48h, capped at 48h).Summary by cubic
Creates shareable links for sent or received emails via a new EmailShareAsync API, enabling external sharing. Previously the client could not generate shareable links; links now accept an optional human-readable expiration that defaults to and is capped at 48h.
Written for commit ebabbba. Summary will update on new commits.