Conversation
Introduce DomainStatus (domain-level) and DomainRecordStatus (record-level) enums, mirroring the split in resend-node. - DomainStatus adds partially_verified and partially_failed (7 values) - DomainRecordStatus retains the 5-value set including temporary_failure - Domain.Status switches from ValidationStatus to DomainStatus - DomainRecord.Status switches from ValidationStatus to DomainRecordStatus - ValidationStatus remains in place for webhook payloads (DomainEventData) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
drish
approved these changes
Apr 20, 2026
This was referenced Apr 20, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add two new domain-level statuses —
partially_verifiedandpartially_failed— and split the status typing so they apply only to domains, not individual DNS records.DomainStatus(domain-level):not_started | pending | failed | verified | partially_verified | partially_failedDomainRecordStatus(record-level):not_started | pending | failed | temporary_failure | verifiedDomain.Statusnow typed asDomainStatusDomainRecord.Statusnow typed asDomainRecordStatusValidationStatusis kept for webhook payloads (DomainEventData) — webhook schema is out of scope for this changeAdds two deserialization tests covering
partially_verifiedandpartially_failed. Also updates theResend.ApiServermock controller to use the new enums.Matches resend/resend-node#936.
Breaking change note
Domain.StatusandDomainRecord.Statusproperty types have changed. Consumers that assigned or compared these againstValidationStatusvalues will need to update to the new enum types.Summary by cubic
Add two new domain statuses and split status enums by scope to align with the Resend API. This changes the types of
Domain.StatusandDomainRecord.Status.New Features
DomainStatuswithpartially_verifiedandpartially_failed.DomainRecordStatus(includestemporary_failure).Domain.Statusnow usesDomainStatus;DomainRecord.StatususesDomainRecordStatus.ValidationStatusfor webhook payloads only.Resend.ApiServermock controller to use the new enums.Migration
ValidationStatusforDomain.StatusandDomainRecord.StatuswithDomainStatusandDomainRecordStatus.ValidationStatusremains).Written for commit 0636f78. Summary will update on new commits.