Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat acleditor UI #3376

Merged
merged 21 commits into from
Mar 25, 2021
Merged

Feat acleditor UI #3376

merged 21 commits into from
Mar 25, 2021

Conversation

quasarchimaere
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Affected Tests have been added/altered (for bug fixes / features)
  • Docs have been reviewed and added/updated if needed (for bug fixes / features)
  • Build was run locally and mvn install succeeds

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently every Atom is created as a Public Atom, everyone can see it, everyone can connect to it (in addition to the acl defined by the sockets)

What is the new behavior?

  • On Create or Edit: Atoms can be public or private now (private: only connected atoms can read the atomContent, everybody can Connect(see Fix private Atoms connect-ACL #3375 for explanation) any available socket acl will STILL be added to the atom) public atoms work as is
  • Refactor Plans UseCases to Events
  • Refactor ACL definitions in detail-definitions.js to use uncompacted vocab
  • Remove all unnecessary ACLs that are already added through the socket-acls

Does this introduce a breaking change?

  • Yes
  • No

Other information

@fkleedorfer fkleedorfer merged commit 5d30fc8 into master Mar 25, 2021
@fkleedorfer fkleedorfer deleted the feat__acleditor_ui branch March 25, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WSOD after sending connect to socket JWTToken parsing
2 participants