Skip to content

Fix printer removing private for empty record #7448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cknitt merged 3 commits into from
May 9, 2025
+12 −0
Merged

Fix printer removing private for empty record #7448

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
928b3f0
Syntax test: reproduce bug
cknitt May 9, 2025
dca2c02
Fix printer removing private for empty record
cknitt May 9, 2025
6606d8b
CHANGELOG
cknitt May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/syntax/src/res_printer.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1289,6 +1289,7 @@ and print_type_declaration2 ?inline_record_definitions ~state ~rec_flag
Doc.space;
Doc.text equal_sign;
Doc.space;
print_private_flag td.ptype_private;
Doc.lbrace;
print_comments_inside cmt_tbl td.ptype_loc;
Doc.rbrace;
Expand Down
5 changes: 5 additions & 0 deletions tests/syntax_tests/data/printer/typeDef/expected/private.res.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type t1 = private {}

type t2 = private {x: int}

type t3 = private A | B
5 changes: 5 additions & 0 deletions tests/syntax_tests/data/printer/typeDef/private.res
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type t1 = private {}

type t2 = private {x: int}

type t3 = private A | B