Array spread syntax support #6608
Conversation
jscomp/syntax/src/res_core.ml
Outdated
| let loc = mkLoc startPos p.prevEndPos in | ||
| let collectExprs = function | ||
| | [], Some spread, _startPos, _endPos -> [spread] | ||
| | exprs, Some spread, _startPos, _endPos -> ( |
There was a problem hiding this comment.
One thing I wasn't so sure if whether I should use startPos and endPos as the location.
|
Awesome! Seems like a few tests fail. |
zth
left a comment
zth
left a comment
There was a problem hiding this comment.
This looks great to me, fantastic job! I'd like @cristianoc to have a look as well.
Also, mind adding a changelog? Also, we could rebase this to the v11 release branch, no reason to wait for v12 to ship this.
|
Looks great |
|
@shulhi want to rebase on 11 (https://github.com/rescript-lang/rescript-compiler/tree/11.0_release) before merging? That'll put it in the next version released. Again, great work! |
shulhi
force-pushed
the
feat/array-spread
branch
from
9df2643 to
dab2ffe
Compare
shulhi
force-pushed
the
feat/array-spread
branch
from
dab2ffe to
c20a745
Compare
I've rebased on 11. Hopefully, it's correct. |
3 participants
Implementation for #6546