Skip to content

Check the runtime representation of variants matches implementation a… #6513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cristianoc merged 1 commit into from
Dec 8, 2023
Merged

Check the runtime representation of variants matches implementation a… #6513

cristianoc merged 1 commit into from
Dec 8, 2023

Conversation

@cristianoc
Copy link
Collaborator

@cristianoc cristianoc commented Dec 7, 2023

…nd interface.

// module M : {
//   @tag("abc")
//   type t = | A(int)
// } =
// {
//   type t = | A(int)
// }

module M : {
  type t = | @as("abc") A
} =
{
  type t = | A
}

@cristianoc cristianoc requested a review from zth December 7, 2023 10:04
zth
zth approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing gets me more excited than PRs to includecore.ml and friends!

cknitt
cknitt reviewed Dec 7, 2023
View reviewed changes
jscomp/ml/includecore.ml Outdated
if err <> [] then err else
let err = match (decl1.type_kind, decl2.type_kind) with
(_, Type_abstract) -> []
(* XXX *)
Copy link
Member

@cknitt cknitt Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover comment?

@cristianoc cristianoc force-pushed the include_check_variant_runtime_repr branch from d5b791e to e3deee2 Compare December 8, 2023 16:45
@cristianoc
Check the runtime representation of variants matches implementation a…
c2bb768 
…nd interface.

```
// module M : {
//   @tag("abc")
//   type t = | A(int)
// } =
// {
//   type t = | A(int)
// }

module M : {
  type t = | @as("abc") A
} =
{
  type t = | A
}
```
@cristianoc cristianoc force-pushed the include_check_variant_runtime_repr branch from e3deee2 to c2bb768 Compare December 8, 2023 16:47
@cristianoc cristianoc merged commit adb55d0 into master Dec 8, 2023
@cristianoc cristianoc deleted the include_check_variant_runtime_repr branch December 8, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cknitt cknitt cknitt left review comments

@zth zth zth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cristianoc @cknitt @zth