Fix issue where generic compare on float values would be different …#6042
Merged
cristianoc merged 6 commits intomasterfrom Mar 6, 2023
Merged
Fix issue where generic compare on float values would be different …#6042cristianoc merged 6 commits intomasterfrom
float values would be different …#6042cristianoc merged 6 commits intomasterfrom
Conversation
…from the compare for type `float` Fixes #6040
d7d0e11 to
6336204
Compare
Contributor
|
Unfortunately still fails on a few cases: eq __LOC__ (generic_lessthan Js.Float._NaN 4.2) false;
eq __LOC__ (generic_greaterthan 4.2 Js.Float._NaN) false;
eq __LOC__ (generic_lessequal Js.Float._NaN Js.Float._NaN) false;
eq __LOC__ (generic_lessequal Js.Float._NaN 4.2) false;
eq __LOC__ (generic_greaterequal Js.Float._NaN Js.Float._NaN) false;
eq __LOC__ (generic_greaterequal 4.2 Js.Float._NaN) false;These are all in #6044 |
Contributor
|
This will also affect |
Collaborator
Author
|
@glennsl should be OK now. |
Contributor
|
Perfect. Thanks! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…from the compare for type
floatFixes #6040