Skip to content

polish(format): improve format check CLI #5893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cristianoc merged 2 commits into from
Dec 9, 2022
Merged

polish(format): improve format check CLI #5893

cristianoc merged 2 commits into from
Dec 9, 2022

Conversation

@aspeddro
Copy link
Contributor

@aspeddro aspeddro commented Dec 9, 2022

Follow up #5760

Didn't know I could check the whole project or pass a set of files.

Changes:

  1. Improve help message
  2. Exit with error code when run rescript format -check

Currently, npx rescript format -check exit with a success

@cristianoc
Copy link
Collaborator

cristianoc commented Dec 9, 2022

You need to format the format script.

@cristianoc cristianoc merged commit 60f6c9d into rescript-lang:master Dec 9, 2022
@aspeddro aspeddro mentioned this pull request Feb 17, 2023
Closed
This was referenced Mar 8, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aspeddro @cristianoc