Skip to content

Sync latest syntax. #5575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cristianoc merged 2 commits into from
Jul 21, 2022
Merged

Sync latest syntax. #5575

cristianoc merged 2 commits into from
Jul 21, 2022

Conversation

@cristianoc
Copy link
Collaborator

@cristianoc cristianoc commented Jul 21, 2022

  • Initial support for JSX V4, still work in progress.
    • 💥 when V4 is activated, at most one component is allowed for each module.

mununki
mununki reviewed Jul 21, 2022
View reviewed changes
jscomp/frontend/ppx_entry.ml
match !Js_config.jsx_version with
| 3 -> Reactjs_jsx_ppx_v3.rewrite_signature ast
| 3 ->
Reactjs_jsx_ppx.rewrite_signature ~jsxVersion:3 ~jsxModule:""
Copy link
Member

@mununki mununki Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be duplicated to #5484

Copy link
Collaborator Author

@cristianoc cristianoc Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to merge this in master.
Then #5484 rebases on top.
A small step, but gets the basic structure into master.

Copy link
Member

@mununki mununki Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got your point!

@cristianoc cristianoc merged commit 724ee3d into master Jul 21, 2022
@cristianoc cristianoc deleted the sync-latest-syntax branch July 21, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mununki mununki mununki left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cristianoc @mununki