Skip to content

Conversation

@cristianoc
Copy link
Contributor

No description provided.

@cristianoc cristianoc requested a review from zth November 5, 2022 07:27
@cristianoc cristianoc added this to the v10.1 milestone Nov 5, 2022
@cristianoc cristianoc mentioned this pull request Nov 5, 2022
57 tasks
Copy link
Member

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

className: "hidden sm:block mr-6"
}, React.createElement(DocSearch.make, {})), React.createElement("a", {
className: "mr-5 no-underline block text-inherit hover:cursor-pointer hover:text-fire-30 text-gray-40 mb-px",
className: "mr-5 " + link,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only inlining difference

Copy link
Member

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍

@ryyppy
Copy link
Member

ryyppy commented Nov 5, 2022

I guess there also need to be changes for the Async & Promise section as well?

@cristianoc cristianoc merged commit 910f9fc into master Nov 6, 2022
@cristianoc cristianoc deleted the async-await branch November 6, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants