This repository was archived by the owner on Apr 24, 2021. It is now read-only.
Try using makefile #137
Merged
Try using makefile #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to make this repo embeddable in others, and we have a few makefile-related workflows to share, so here we are. Pros: - No dep on dune. There's been a few install-time conflicts in the past. Dune also isn't small. - Easier embedding. - Simpler setup. Entropy-- - Easier integration with tests. Cons: - Less convenient than dune at times. Now we're maintaining a makefile. - Dune does incrementalism a better than makefiles. Build speed is around the same.
Closed
chenglou
added a commit
that referenced
this pull request
Apr 20, 2021
See #137 First part. Will update with the recent setup-ocaml and other changes later
chenglou
added a commit
that referenced
this pull request
Apr 20, 2021
See #137 First part. Will update with the recent setup-ocaml and other changes later
chenglou
added a commit
to chenglou/rescript-editor-support
that referenced
this pull request
Apr 24, 2021
See rescript-lang#137 First part. Will update with the recent setup-ocaml and other changes later
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make this repo embeddable in others, and we have a few makefile-related workflows to share, so here we are.
Pros:
Cons:
Build speed is around the same.