Skip to content

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 13, 2025

Related

What

Ever since we actually cut off the range queries correctly (in #7133) we queried an extra scalars at the start and end of the range. For points that obviously wrong, for lines we have to cut the lines to the range - this caused the stuttering described & demonstrated in #9270

I fixed this for points only here since it's trivial.

@Wumpf Wumpf added this to the 0.23.3 (?) milestone May 13, 2025
@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog feat-plots Plots, charts, graphs, timeseries, … labels May 13, 2025
Copy link

github-actions bot commented May 13, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
6a0a560 https://rerun.io/viewer/pr/9963 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf changed the title Fix time series points querying extra points at start and end of time range Fix time series points querying extra points at start and end of time range (causing stuttering on playback in some scenes) May 13, 2025
@grtlr grtlr self-requested a review May 19, 2025 13:23
Copy link
Contributor

@grtlr grtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Wumpf Wumpf merged commit 75667ce into main May 19, 2025
46 of 48 checks passed
@Wumpf Wumpf deleted the andreas/fix-time-series-point-lookahead branch May 19, 2025 13:43
jprochazk pushed a commit that referenced this pull request May 24, 2025
… range (causing stuttering on playback in some scenes) (#9963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working feat-plots Plots, charts, graphs, timeseries, … include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants