-
Notifications
You must be signed in to change notification settings - Fork 529
Series of build changes for web release to minimize generated wasm #9870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
One thing that I don't have time to check right now is if the wasm build still works. There is a script in |
At least part of it is failing, but I need to step away. I'll pick this back up monday morning. |
…the profile name accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. @jprochazk would you think it's worth triggering an alpha to test the build?
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/14882034563 |
Still need to take a closer look at how this affects the build script, adding DNM for now |
I've got some commits coming soon to fix the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gzip .wasm
is under 9MB now, so we've got some time before we have to think about this again
…9870) Co-authored-by: jprochazk <[email protected]> Co-authored-by: Jan Procházka <[email protected]>
Related
The recent addition of datafusion dependency has made our wasm size too large to upload to some places. This PR introduces a series of build options to reduce the blob size.
What
This PR adds a build profile specific to minimizing file size. Additionally it changes the web build tool to use this profile when the
--release
parameter is set.