Improve UI for arrow components #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
force-pushed
the
emilk/arrow-data-ui
branch
from
5c13127 to
b1a3469
Compare
emilk
force-pushed
the
emilk/arrow-data-ui
branch
from
b1a3469 to
f668c6e
Compare
emilk
commented
Jan 19, 2023
| } | ||
| } | ||
|
|
||
| pub fn format_field_or_component_name(name: &FieldOrComponent) -> String { |
There was a problem hiding this comment.
Soon we can get rid of this, when we delete the non-arrow code
Wumpf
approved these changes
Jan 20, 2023
| display(&mut repr, 0).unwrap(); | ||
| ui.label(repr); | ||
| } else { | ||
| ui.label(format!("{} bytes", bytes)); |
There was a problem hiding this comment.
full display on hover still?
it rarely makes sense to show number of bytes, maybe it would be better to cut off the display string? with ...?
There was a problem hiding this comment.
If it is this big it is likely a binary blob, so displaying it is probably not very useful. We never hit this path with any standard component btw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #675
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)