Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make arrow the default storage #823

Merged
merged 6 commits into from
Jan 20, 2023
Merged

Make arrow the default storage #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4f9d040
Make arrow the default on debug builds
jleibs Jan 18, 2023
12038bf
Make Arrow the default and update changelog
jleibs Jan 18, 2023
358ee0c
Clarify changelog
jleibs Jan 18, 2023
9f0b120
Merge branch 'main' into jleibs/arrow_default
emilk Jan 19, 2023
9467b3e
Merge branch 'main' into jleibs/arrow_default
emilk Jan 20, 2023
ef76839
Merge branch 'main' into jleibs/arrow_default
emilk Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

A rough time-line of major user-facing things added, removed and changed. Newest on top.

* 2022-01-20: Arrow Storage is now the default storage backend for rerun. Use RERUN_STORE=classic to opt out. [#822](https://github.com/rerun-io/rerun/pull/822).
* 2022-01-19: `rerun.spawn_and_connect` - the easiest way to use Rerun [#821](https://github.com/rerun-io/rerun/pull/821).
* 2022-01-16: Added a command palette (Ctrl-P or Cmd-P) [#656](https://github.com/rerun-io/rerun/pull/656).
* 2022-01-13: Introduce RERUN_STORAGE environment variable to choose storage mechanism [#752](https://github.com/rerun-io/rerun/pull/752).
Expand Down
7 changes: 1 addition & 6 deletions crates/rerun_sdk/src/session.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,7 @@ enum StoreSelect {
Mixed,
}

// TODO(#707): Make this the default for Debug-builds, and eventually release builds
//#[cfg(debug_assertions)]
//const DEFAULT_STORE: StoreSelect = StoreSelect::Arrow;

//#[cfg(not(debug_assertions))]
const DEFAULT_STORE: StoreSelect = StoreSelect::Classic;
const DEFAULT_STORE: StoreSelect = StoreSelect::Arrow;

lazy_static! {
static ref ARROW_PREFIX: InternedString = "arrow".into();
Expand Down