Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate and show video frame number #8112

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Calculate and show video frame number #8112

merged 8 commits into from
Nov 13, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Nov 13, 2024

What

Show frame number in selection panel when selecting a video.

image

We may want to make it more prominent though? 🤔

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf self-requested a review November 13, 2024 10:12
@emilk emilk added the 📺 re_viewer affects re_viewer itself label Nov 13, 2024
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to make it more prominent though? 🤔

Yeah now that we're confident enough with this (I think we are!) this might be together with the expandy-area in "top-level" 🤔

crates/store/re_video/src/demux/mp4.rs Outdated Show resolved Hide resolved
@emilk
Copy link
Member Author

emilk commented Nov 13, 2024

I'll go with this:
image

@emilk emilk merged commit 1785f20 into main Nov 13, 2024
34 checks passed
@emilk emilk deleted the emilk/frame-nr branch November 13, 2024 11:15
@emilk emilk changed the title Calculate and show frame number Calculate and show video frame number Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants